linux-kernel - Re: Badness at net/ipv4/inet_connection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091214.111105.224947761.davem@davemloft.net>
Date:	Mon, 14 Dec 2009 11:11:05 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	john.dykstra1@...il.com
Cc:	eric.dumazet@...il.com, lists@...dbynature.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: Badness at net/ipv4/inet_connection_sock.c:293

From: John Dykstra <john.dykstra1@...il.com>
Date: Mon, 14 Dec 2009 18:57:13 +0000

> That test was changed to match a change in the return values of
> tcp_ack().  No logic change was intended.

As Eric pointed out, changing tcp_ack()'s behavior effects state
transitions out of SYN_ACK, so this commit is very likely the culprit.

I usually see 2 or 3 three of these bug triggers in the first ten
minutes after bootup and I haven't seen one yet in 20 minutes
with the commit reverted.

This change is definitely wrong.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/