linux-kernel - Re: [PATCH] Logitech G13 driver against torvalds/linux-2.6.git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091214194840.GA7033@kroah.com>
Date:	Mon, 14 Dec 2009 11:48:40 -0800
From:	Greg KH <greg@...ah.com>
To:	"Rick L. Vinyard, Jr." <rvinyard@...nmsu.edu>
Cc:	Linux <linux-kernel@...r.kernel.org>,
	Linux Input <linux-input@...r.kernel.org>,
	Linux USB <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] Logitech G13 driver against torvalds/linux-2.6.git


Great first cut, but please:
	- your patch was linewrapped, please fix your email client to
	  not do that.
	- You did not provide a signed-off-by: line as required by the
	  file Documentation/SubmittingPatches
	- You did not provide a good changelog entry in the body of the
	  email explaining what this patch is, and what it does.
	- you did not cc: the HID maintainer, who is the proper person
	  to apply this patch.  Try using the script,
	  scripts/get_maintainer.pl to figure out who to send patches
	  to.
	- Can you run your patch through the scripts/checkpatch.pl
	  script and fix the errors and warnings it reports?  It would
	  have caught many of the above mentioned things.

Care to try again?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/