linux-kernel - Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Dec 2009 15:48:43 -0700
From:	"Rick L. Vinyard, Jr." <rvinyard@...nmsu.edu>
To:	felipe.balbi@...ia.com
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"krzysztof.h1@...pl" <krzysztof.h1@...pl>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"oliver@...kum.org" <oliver@...kum.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"jkosina@...e.cz" <jkosina@...e.cz>
Subject: Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others)

Hello,

Felipe Balbi wrote:
> On Mon, Dec 14, 2009 at 10:22:32PM +0100, ext Rick L. Vinyard Jr. wrote:
>>
>>Signed-off-by: Rick L. Vinyard, Jr <rvinyard@...nmsu.edu>
>
> there are plenty of style mistakes in this patch. the body message
> description which you put below should be above the signed-off-by line,

Fixed in the new patch labelled 0.0.2

> multi-lined comments are of the form:
>
> /*
>   * multi lined comment
>   * goes here
>   */
>

Fixed

> remove the commented code like /* hid_debug = 0 */
>

Removed

> and some others.. please run your patch through scripts/checkpatch.pl
> --strict and fix the errors and warnings reported.
>

I ran it without the --strict option before. That's probably why I didn't
catch it. It's clean now with --strict.

>>+static int __init g13_init(void)
>>+{
>>+       pr_debug("g13 HID driver loaded");
>
> don't pr_debug() here.
>

Removed

>>+       return hid_register_driver(&g13_driver);
>>+}
>>+
>>+static void __exit g13_exit(void)
>>+{
>>+       pr_debug("g13 HID driver unloaded");
>
> nor here.
>
>>+       hid_unregister_driver(&g13_driver);
>>+}

Removed

Thanks for the input. Everything above is taken into account in v0.0.2 of
the patch.

---

Rick

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/