linux-kernel - Re: BUG null dereference in driver ./drivers/net/3c507.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200912151514.34693.bzolnier@gmail.com>
Date:	Tue, 15 Dec 2009 15:14:34 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Alexander Strakh <strakh@...ras.ru>
Cc:	Donald Becker <becker@...ld.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: BUG null dereference in driver ./drivers/net/3c507.c


Hi,

On Tuesday 15 December 2009 06:55:08 pm Alexander Strakh wrote:
> 	KERNEL_VERSION: 2.6.32
> 	SUBJECT: null dereference aftre check
> 	DESCRIBE:
> 	In driver drivers/net/3c507.c in function Iirqreturn_t el16_interrupt:
> 
> 1. If in line 555 dev = NULL then we goto line 556
> 2. In line 556 we have null dereference because pr_err called with dev->name 
> in third parameter.
> 
>  555        if (dev == NULL) {
>  556                pr_err("%s: net_interrupt(): irq %d for unknown device.
> \n",
>  557                        dev->name, irq);
>  558                return IRQ_NONE;
>  559        }

There is no NULL dereference bug there possible since 'dev' will never be
actually NULL in el16_interrupt() (because of the way IRQ kernel subsystem
and 3c507 network driver are designed/work).

IOW it is just a bogus NULL pointer check, though it still would be nice
to have the issue fixed.  Care to send a patch removing it?

--
Bartlomiej Zolnierkiewicz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/