linux-kernel - Re: BUG null dereference in driver ./drivers/isdn/icn/icn.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200912151520.48798.bzolnier@gmail.com>
Date:	Tue, 15 Dec 2009 15:20:48 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Alexander Strakh <strakh@...ras.ru>
Cc:	Fritz Elfert <fritz@...n4linux.de>,
	Karsten Keil <isdn@...ux-pingi.de>,
	Armin Schindler <mac@...ware.de>, linux-kernel@...r.kernel.org
Subject: Re: BUG null dereference in driver ./drivers/isdn/icn/icn.c

On Tuesday 15 December 2009 06:55:06 pm Alexander Strakh wrote:
> 	KERNEL_VERSION: 2.6.32
> 	SUBJECT: null dereference after check
> 	DESCRIBE:
> 	In driver ./drivers/isdn/icn/icn.c in function icn_addcard:
> 
> 1. If in line 1580 card2 = NULL  then we goto line 1581
> 2. In line 1581 we have null dereference because printk called with card2-
> >interface.id in third parameter.
> 
> 1580        if (!(card2 = icn_initcard(port, id2))) {
> 1581                printk(KERN_INFO
> 1582                       "icn: (%s) half ICN-4B, port 0x%x added\n",
> 1583                       card2->interface.id, port);
> 1584                return 0;
> 1585        }

After reading icn_addcard() it seems like the code was meant to use
'card' not 'card2' there.

--
Bartlomiej Zolnierkiewicz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/