linux-kernel - Re: [PATCH resend] x86, amd: Get multi-node CPU info from NodeId MSR instead of PCI config space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <uqtdsfmgx5kgsducseo3254j.1260906697878@email.android.com>
Date:	Tue, 15 Dec 2009 11:51:37 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Ingo Molnar <mingo@...e.hu>,
	Andreas Herrmann <herrmann.der.user@...glemail.com>
CC:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend] x86, amd: Get multi-node CPU info from NodeId MSR instead of PCI config space

Absolutely - the only place for MSR numbers is in msr-index.h

"Ingo Molnar" <mingo@...e.hu> wrote:

>
>* Andreas Herrmann <herrmann.der.user@...glemail.com> wrote:
>
>> +	rdmsrl(0xc001100c, value);
>
>Dont we want some nice, meaningfully named symbolic constant here, instead of 
>0xc001100c?
>
>	Ingo

--
Sent from my mobile phone. Please excuse any lack of formatting.