lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20091215213005.GB9554@quack.suse.cz>
Date:	Tue, 15 Dec 2009 22:30:05 +0100
From:	Jan Kara <jack@...e.cz>
To:	Joe Perches <joe@...ches.com>
Cc:	Jerry Leo <jerryleo860202@...il.com>, jack@...e.cz,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] quota: integer constant is too large for ‘long’ type in

On Tue 15-12-09 07:24:14, Joe Perches wrote:
> On Tue, 2009-12-15 at 21:27 +0800, Jerry Leo wrote:
> > -               info->dqi_maxblimit = 0xffffffffffffffff;       /* 2^64-1 */
> > -               info->dqi_maxilimit = 0xffffffffffffffff;
> > +               info->dqi_maxblimit = 0xFFFFFFFFFFFFFFFFLL;     /* 2^64-1 */
> > +               info->dqi_maxilimit = 0xFFFFFFFFFFFFFFFFLL;
> 
> ULLONG_MAX?
  Not quite - I want it to really be 2^64 - 1 (on disk type is u64)
so ULLONG_MAX would be confusing IMHO.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ