linux-kernel - [PATCH] SYSCTL: Fix sysctl breakage on systems with older glibc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091216112844.GA31705@basil.fritz.box>
Date:	Wed, 16 Dec 2009 12:28:44 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	ebiederm@...ssion.com, akpm@...ux-foundation.org,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: [PATCH] SYSCTL: Fix sysctl breakage on systems with older glibc

SYSCTL: Fix breakage on systems with older glibc

As predicted during code review, the sysctl(2) changes made systems
with old glibc nearly unusable. About every command gives a:

warning: process `ls' used the deprecated sysctl s ystem call with 1.4

warning in the log.

I see this on a SUSE 10.0 system with glibc 2.3.5.
Don't warn for this common case.

Signed-off-by: Andi Kleen <ak@...ux.intel.com>

diff -u linux-2.6.32-git12/kernel/sysctl_binary.c-o linux-2.6.32-git12/kernel/sysctl_binary.c
--- linux-2.6.32-git12/kernel/sysctl_binary.c-o	2009-12-16 12:15:52.000000000 +0100
+++ linux-2.6.32-git12/kernel/sysctl_binary.c	2009-12-16 12:14:58.000000000 +0100
@@ -1399,6 +1399,13 @@
 {
 	int i;
 
+	/* 
+	 * CTL_KERN/KERN_VERSION is used by older glibc and cannot 
+	 * ever go away.
+	 */
+	if (name[0] == CTL_KERN && name[1] == KERN_VERSION)
+		return;
+
 	if (printk_ratelimit()) {
 		printk(KERN_INFO
 			"warning: process `%s' used the deprecated sysctl "
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/