linux-kernel - Re: [PATCH] gianfar: Fix tests of unsigneds in gfar_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25e057c00912160748x504cb4c1ibaa3ab6d26864525@mail.gmail.com>
Date:	Wed, 16 Dec 2009 16:48:00 +0100
From:	roel kluin <roel.kluin@...il.com>
To:	Kumar Gopalpet-B05799 <B05799@...escale.com>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gianfar: Fix tests of unsigneds in gfar_parse_group()

On Wed, Dec 16, 2009 at 6:04 AM, Kumar Gopalpet-B05799
<B05799@...escale.com> wrote:
>
>>Won't it be better to change types of interruptTransmit,
>>-Receive and -Error in  struct gfar_priv_grp itself. Something
>>like this:

> struct gfar_priv_grp {
> ....
> -       unsigned int interruptTransmit;
> -       unsigned int interruptReceive;
> -       unsigned int interruptError;
>
> +       int interruptTransmit;
> +       int interruptReceive;
> +       int interruptError;
> ....
> }
>
> --
>
> Thanks
> Sandeep

I don't think that's better. Only the error returned is signed,
If none occurred the irq thereafter is unsigned.

Thanks,

Roel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/