linux-kernel - Re: [PATCH] move eject code from zd1211rw to usb-storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1260982037.2179.5.camel@localhost.localdomain>
Date:	Wed, 16 Dec 2009 08:47:17 -0800
From:	Dan Williams <dcbw@...hat.com>
To:	Stefan Seyfried <stefan.seyfried@...glemail.com>
Cc:	Josua Dietze <digidietze@...isberghof.de>,
	Matthew Dharm <mdharm-kernel@...-eyed-alien.net>,
	Oliver Neukum <oliver@...kum.org>, linux-usb@...r.kernel.org,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	usb-storage@...ts.one-eyed-alien.net
Subject: Re: [PATCH] move eject code from zd1211rw to usb-storage

On Wed, 2009-12-16 at 13:14 +0100, Stefan Seyfried wrote:
> On Wed, 16 Dec 2009 12:22:31 +0100
> Josua Dietze <digidietze@...isberghof.de> wrote:
> 
> > Stefan Seyfried schrieb:
> > > Preferably some code that can be built actually?
> > 
> > If the "eject" from SCSI tools does not work, "usb_modeswitch" can 
> > send customized bulk messages to devices.
> 
> for my device, eject seems to be enough, so I'll be trying to get
> this into udev.
> 
> > http://www.draisberghof.de/usb_modeswitch/
> 
> Unfortunately it cannot be built with current libusb and once you
> compile it without warnings turned off (which is the default!), you
> probably don't want to run it anymore ;)

At this point, however, usb_modeswitch is the correct place to put eject
code for all devices.  I wouldn't put this code into udev; I'd put it
into usb_modeswitch instead, since usb_modeswitch is (a) the de-facto
standard, (b) has the most users, and (c) has the most devices.  Yes, it
has problems, but at this point we should fix those problems instead of
creating 5 different eject tools.

Dan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/