linux-kernel - Re: [tip:sched/urgent] sched: Teach might

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091216185723.GA5211@nowhere>
Date:	Wed, 16 Dec 2009 19:57:32 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-tip-commits@...r.kernel.org,
	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	peterz@...radead.org, tglx@...utronix.de
Subject: Re: [tip:sched/urgent] sched: Teach might_sleep() about
	preemptible RCU

On Wed, Dec 16, 2009 at 07:30:20AM -0800, Paul E. McKenney wrote:
> On Wed, Dec 16, 2009 at 03:25:36PM +0100, Ingo Molnar wrote:
> > 
> > * tip-bot for Frederic Weisbecker <fweisbec@...il.com> wrote:
> > 
> > > Commit-ID:  ba1b1cbcc9b458c4b9ebb28c9cf6a2ccf64ba1cd
> > > Gitweb:     http://git.kernel.org/tip/ba1b1cbcc9b458c4b9ebb28c9cf6a2ccf64ba1cd
> > > Author:     Frederic Weisbecker <fweisbec@...il.com>
> > > AuthorDate: Mon, 14 Dec 2009 23:44:32 +0100
> > > Committer:  Ingo Molnar <mingo@...e.hu>
> > > CommitDate: Wed, 16 Dec 2009 08:43:16 +0100
> > > 
> > > sched: Teach might_sleep() about preemptible RCU
> > 
> > Causes a build failure, so skipped this patch for now:
> > 
> > kernel/sched.c:9661: error: implicit declaration of function 'rcu_preempt_depth'
> 
> I guess my testing missed something.  :-/  Could you please send the
> .config file that caused this?
> 
> 							Thanx, Paul


Looks like the problem is here:

rcupdate.h:

	#if defined(CONFIG_TREE_RCU) || defined(CONFIG_TREE_PREEMPT_RCU)
	#include <linux/rcutree.h>
	#elif defined(CONFIG_TINY_RCU)
	#include <linux/rcutiny.h>

I guess it barfs in rcutiny configs.

I should define these helpers in rcupdate.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/