| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20091216195935.GA551@ldl.fc.hp.com> Date: Wed, 16 Dec 2009 12:59:35 -0700 From: Alex Chiang <achiang@...com> To: Mikulas Patocka <mpatocka@...hat.com> Cc: linux-kernel@...r.kernel.org, Linus Torvalds <torvalds@...ux-foundation.org>, Alasdair G Kergon <agk@...hat.com>, dm-devel@...hat.com Subject: Re: [PATCH] Drop 80-character limit in checkpatch.pl I've no comments on the actual patch but... * Mikulas Patocka <mpatocka@...hat.com>: > Drop 80-character limit in checkpatch.pl > > Serious issues: > =============== > > (1) The code is hard to edit with common text editors You mention vi; most distros provide vim these days. In my .vimrc, I have: set ai set si That helps a bit. > (2) Grepping the code is unreliable Reviewers (at least in my part of the kernel) have been requesting that user-visible (and thus developer greppable) output be combined on one line precisely for this reason. We've been rejecting patches that unnecessarily break up these strings at 80 cols. > But some maintainers take output of the script checkpatch.pl > dogmatically, requiring that every new work must pass the > script without a warning. This is the real problem. And I think the solution is to lobby your maintainer. fwiw, /ac -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists