linux-kernel - Re: [patch 1/1] devtmpfs: Convert dirlock to a mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091216221541.GA8707@suse.de>
Date:	Wed, 16 Dec 2009 14:15:41 -0800
From:	Greg KH <gregkh@...e.de>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Kay Sievers <kay.sievers@...y.org>
Subject: Re: [patch 1/1] devtmpfs: Convert dirlock to a mutex

On Wed, Dec 16, 2009 at 09:31:33PM -0000, Thomas Gleixner wrote:
> devtmpfs has a rw_lock dirlock which serializes delete_path and
> create_path.
> 
> This code was obviously never tested with the usual set of debugging
> facilities enabled. In the dirlock held sections the code calls:
> 
>  - vfs functions which take mutexes
>  - kmalloc(, GFP_KERNEL)
> 
> In both code pathes the might sleep warning triggers and spams dmesg.
> 
> Convert the rw_lock to a mutex. There is no reason why this needs to
> be a rwlock.

Many thanks, this is correct.  I'll go queue it up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/