linux-kernel - Re: [PATCH 0/9] pci: update pci bridge resource to get more big range for devices under it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091216224445.GA24763@ldl.fc.hp.com>
Date:	Wed, 16 Dec 2009 15:44:45 -0700
From:	Alex Chiang <achiang@...com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Bjorn Helgaas <bjorn.helgaas@...com>,
	Ingo Molnar <mingo@...e.hu>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH 0/9] pci: update pci bridge resource to get more big
	range for devices under it - v13

* Yinghai Lu <yinghai@...nel.org>:
> Alex Chiang wrote:
> > * Jesse Barnes <jbarnes@...tuousgeek.org>:
> >>
> >> Patches 7-9 seem like they've recieved some review from Alex
> >> and Kenji-san, but I don't see acks or reviewed-bys on them.
> >>
> >> Alex and Kenji-san, are you ok with them assuming the
> >> previous patches or something like them go upstream?
> > 
> > Can you please repost your next revision (after taking
> > Jesse's review comments) in a new thread?
> > 
> 
> can you check
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-2.6-yinghai.git
> >> master
> 
> http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-2.6-yinghai.git;a=shortlog;h=refs/heads/master
> 
> i rebased them to linus tree 12-12-2009.

Well, yes, I can read those, but now I have to try and guess 
which patches are 7-9 that Jesse asked me to review.

One reason that it's hard to review your patches is because there 
are many revisions, buried deep within threads. It's not easy for 
reviewers to a) keep track of all them or b) keep track of how 
they inter-relate.

I might be following one subthread, see N revisions for patch x/y 
as replies in there, keep track of the changes mentally, and then 
keep all that state in my mind as I navigate around in the thread 
to try and review patch x+1/y.

Then, trying to figure out how x, x+1, x+2 are all related into 
one coherent change is difficult.

In the future, for PCI patch series, when you have to make 
revisions, please repost as a new thread every time. This will 
make life much easier for reviewers.

Thanks,
/ac

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/