linux-kernel - HTC Dream camera, not need sizeof

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200912170513.45388@PAVLINUX->
Date:	Thu, 17 Dec 2009 05:13:45 +0300
From:	Pavel Vasilyev <pavel@...linux.ru>
To:	linux-kernel@...r.kernel.org
Subject: HTC Dream camera, not need sizeof

        http://bugzilla.kernel.org/show_bug.cgi?id=14825


  On line 258,  sizeof(extlen), always will be sizeof( unit32_t) or 4  

  It seems that something is wrong?!?!  :)


Original 

 255    extlen = sizeof(struct vfe_frame_extra);
 256
 257        extdata =
 258                kmalloc(sizeof(extlen), GFP_ATOMIC);

is equal         kmalloc(sizeof(uint32_t), GFP_ATOMIC);
But then do not need to calculate the size of the structure - 
sizeof(vfe_frame_extra) ???

 259        if (!extdata) {
 260                rc = -ENOMEM;
 261                goto init_fail;

---------------------
May be next?


diff --git a/drivers/staging/dream/camera/msm_vfe7x.c 
b/drivers/staging/dream/camera/msm_vfe7x.c
index 33ab3ac..4d39848 100644
--- a/drivers/staging/dream/camera/msm_vfe7x.c
+++ b/drivers/staging/dream/camera/msm_vfe7x.c
@@ -256,7 +256,7 @@ static int vfe_7x_init(struct msm_vfe_callback *presp,
        extlen = sizeof(struct vfe_frame_extra);

        extdata =
-               kmalloc(sizeof(extlen), GFP_ATOMIC);
+               kmalloc(extlen, GFP_ATOMIC);
        if (!extdata) {
                rc = -ENOMEM;
                goto init_fail;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/