[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20091216185627.2ea4f3d8@jbarnes-piketon>
Date: Wed, 16 Dec 2009 18:56:27 -0800
From: Jesse Barnes <jbarnes@...tuousgeek.org>
To: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: linux-pci@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
blofeldus@...oo.com, Olof Johansson <olof@...om.net>
Subject: Re: [PATCH] cardbus: Add a fixup hook and fix powerpc
On Wed, 09 Dec 2009 17:52:13 +1100
Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:
> The cardbus code creates PCI devices without ever going through the
> necessary fixup bits and pieces that normal PCI devices go through.
>
> There's in fact a commented out call to pcibios_fixup_bus() in there,
> it's commented because ... it doesn't work.
>
> I could make pcibios_fixup_bus() do the right thing on powerpc easily
> but I felt it cleaner instead to provide a specific hook
> pci_fixup_cardbus for which a weak empty implementation is provided
> by the PCI core.
>
> This fixes cardbus on powerbooks and probably all other PowerPC
> platforms which was broken completely for ever on some platforms and
> since 2.6.31 on others such as PowerBooks when we made the DMA ops
> mandatory (since those are setup by the fixups).
>
> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Ah the link failure was my fault. I had fixed up the conflict
incorrectly. It's applied now.
--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists