linux-kernel - Re: [PATCH 2/3 v2] sh: fix DMA driver's descriptor chaining and cookie assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29ab51dc0912161909r7a6e5397sc751a49a636d755d@mail.gmail.com>
Date:	Thu, 17 Dec 2009 12:09:53 +0900
From:	Nobuhiro Iwamatsu <iwamatsu@...auri.org>
To:	Paul Mundt <lethal@...ux-sh.org>
Cc:	Guennadi Liakhovetski <g.liakhovetski@....de>,
	linux-kernel@...r.kernel.org,
	Dan Williams <dan.j.williams@...el.com>,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH 2/3 v2] sh: fix DMA driver's descriptor chaining and 
	cookie assignment

Hi,

2009/12/12 Nobuhiro Iwamatsu <iwamatsu@...auri.org>:
> Hi,
>
> Oh, I was going to check an old patch.
>
> 2009/12/11 Paul Mundt <lethal@...ux-sh.org>:
>> On Thu, Dec 10, 2009 at 06:35:11PM +0100, Guennadi Liakhovetski wrote:
>>> The SH DMA driver wrongly assigns negative cookies to transfer descriptors,
>>> also, its chaining of partial descriptors is broken. The latter problem is
>>> usually invisible, because maximum transfer size per chunk is 16M, but if you
>>> artificially set this limit lower, the driver fails. Since cookies are also
>>> used in chunk management, both these problems are fixed in one patch. As side
>>> effects a possible memory leak, when descriptors are prepared, but not
>>> submitted, and multiple races have also been fixed.
>>>
>>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@....de>
>>
>> Looks good to me.
> Me too.
>
> But I want to check other CPU of sh. I will do next week.
> Please wait "Acked-by".
>
>

I tested this patch. But I can not apply to Paul's git/HEAD.
I re-create patch and I attached.
This version of patch work fine.
Guennadi, could you test this patch on sh7724?

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

View attachment "sh-fix-DMA-driver-s-descriptor-chaining-and-cookie-a.patch" of type "text/plain" (16708 bytes)