[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4B29BFF1.6090304@redhat.com>
Date: Thu, 17 Dec 2009 00:21:53 -0500
From: Masami Hiramatsu <mhiramat@...hat.com>
To: "H. Peter Anvin" <hpa@...or.com>
CC: Roland Dreier <rdreier@...co.com>,
Andrew Isaacson <adi@...are.com>,
Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
Rob Landley <rob@...dley.net>
Subject: Re: CONFIG_KPROBES=y build requires gawk
H. Peter Anvin wrote:
> On 12/16/2009 08:09 PM, Roland Dreier wrote:
>>
>> > > Is there any reason not to apply the patch below, to allow more awk
>> > > implementations to be used? After all, it's not like we're going to put
>> > > non-ASCII characters into the map file...
>>
>> > I guess the question is if it will break under any other circumstances,
>> > but I guess we can find those when we get to them.
>>
>> I should have mentioned it, but with the current Debian testing version
>> (mawk 1.3.3-15) and my patch, I get a byte-for-byte identical
>> inat-tables.c to what I get with the unpatched kernel and gawk
>> 1:3.1.6.dfsg-4.
>>
>> I'm not sure how likely all this is to change in the future, but it's
>> hard for me to see a sane reason why eg [:lower:] and a-z would be
>> different for this use.
>>
>
> If LC_COLL != C they can be. The solution would be to force LC_COLL=C.
Hmm, it's complicated :(. Peter, Roland, I don't want to be annoyed
by those environmental variables. If my last suggestion is acceptable,
could you do as below on your patch :)?
> Ualpha = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
> Lalpha = "abcdefghijklmnopqrstuvwxyz"
> alpha = Ualpha Lalpha
> digit = "0123456789"
> alnum = alpha digit
>
> and replace character classes with it. ("[[:alpha:]]"->"[" alpha "]")
Thank you,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists