linux-kernel - Re: CONFIG_KPROBES=y build requires gawk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B29C652.5080803@redhat.com>
Date:	Thu, 17 Dec 2009 00:49:06 -0500
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	"H. Peter Anvin" <hpa@...or.com>
CC:	Roland Dreier <rdreier@...co.com>, Michal Marek <mmarek@...e.cz>,
	Andrew Isaacson <adi@...are.com>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	Rob Landley <rob@...dley.net>
Subject: Re: CONFIG_KPROBES=y build requires gawk

H. Peter Anvin wrote:
> On 12/16/2009 09:11 PM, Roland Dreier wrote:
>>
>>  > As Al Viro said, if we run awk with LC_ALL=C, then the characters will be
>>  > sorted as ASCII. So, your patch is OK if you can add LC_ALL=C just before
>>  > $(AWK). (I'm not so sure whether Makefile can accept it...)
>>
> 
> I would strongly prefer the following solution as it solves this entire
> class of problems globally, although I'd really want Michal's ACK for it:

Sure, agreed.
BTW, is it possible user to overwrite this setting?

Thank you,

> 
> diff --git a/Makefile b/Makefile
> index 33d4732..7fefc13 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -302,6 +302,10 @@ MAKEFLAGS += --include-dir=$(srctree)
>  $(srctree)/scripts/Kbuild.include: ;
>  include $(srctree)/scripts/Kbuild.include
> 
> +# Avoid funny character set dependencies
> +LC_ALL=C
> +export LC_ALL
> +
>  # Make variables (CC, etc...)
> 
>  AS		= $(CROSS_COMPILE)as
> 
> 

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/