[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091217093524.GA13739@lst.de>
Date: Thu, 17 Dec 2009 10:35:24 +0100
From: Christoph Hellwig <hch@....de>
To: Al Viro <viro@...IV.linux.org.uk>
Cc: Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
Linus Torvalds <torvalds@...ux-foundation.org>,
Christoph Hellwig <hch@....de>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Andrew Morton <akpm@...ux-foundation.org>,
Dave Chinner <david@...morbit.com>,
Badari Pulavarty <pbadari@...ibm.com>,
Jeff Moyer <jmoyer@...hat.com>,
Jens Axboe <jens.axboe@...cle.com>,
Zach Brown <zach.brown@...cle.com>,
Alex Elder <aelder@....com>, Mark Fasheh <mfasheh@...e.com>,
Joel Becker <joel.becker@...cle.com>
Subject: Re: -tip: origin tree boot crash
On Thu, Dec 17, 2009 at 09:32:16AM +0000, Al Viro wrote:
> diff --git a/fs/direct-io.c b/fs/direct-io.c
> index 4012885..e82adc2 100644
> --- a/fs/direct-io.c
> +++ b/fs/direct-io.c
> @@ -1206,7 +1206,7 @@ __blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode,
> * NOTE: filesystems with their own locking have to handle this
> * on their own.
> */
> - if (dio->flags & DIO_LOCKING) {
> + if (flags & DIO_LOCKING) {
> if (unlikely((rw & WRITE) && retval < 0)) {
> loff_t isize = i_size_read(inode);
> if (end > isize)
Hmm, yes that should fix it. Dio is freed at that point.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists