[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20091217004707.472856791@mini.kroah.org>
Date: Wed, 16 Dec 2009 16:45:55 -0800
From: Greg KH <gregkh@...e.de>
To: linux-kernel@...r.kernel.org, stable@...nel.org
Cc: stable-review@...nel.org, torvalds@...ux-foundation.org,
akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
Csaba Henk <csaba@...ster.com>,
Miklos Szeredi <mszeredi@...e.cz>,
Harshavardhana <harsha@...ster.com>
Subject: [04/18] fuse: reject O_DIRECT flag also in fuse_create
2.6.27-stable review patch. If anyone has any objections, please let us know.
------------------
From: Csaba Henk <csaba@...ster.com>
commit 1b7323965a8c6eee9dc4e345a7ae4bff1dc93149 upstream.
The comment in fuse_open about O_DIRECT:
"VFS checks this, but only _after_ ->open()"
also holds for fuse_create, however, the same kind of check was missing there.
As an impact of this bug, open(newfile, O_RDWR|O_CREAT|O_DIRECT) fails, but a
stub newfile will remain if the fuse server handled the implied FUSE_CREATE
request appropriately.
Other impact: in the above situation ima_file_free() will complain to open/free
imbalance if CONFIG_IMA is set.
Signed-off-by: Csaba Henk <csaba@...ster.com>
Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>
Cc: Harshavardhana <harsha@...ster.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
---
fs/fuse/dir.c | 3 +++
1 file changed, 3 insertions(+)
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -401,6 +401,9 @@ static int fuse_create_open(struct inode
if (flags & O_DIRECT)
return -EINVAL;
+ if (flags & O_DIRECT)
+ return -EINVAL;
+
forget_req = fuse_get_req(fc);
if (IS_ERR(forget_req))
return PTR_ERR(forget_req);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists