[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20091217121617.GA14088@elte.hu>
Date: Thu, 17 Dec 2009 13:16:17 +0100
From: Ingo Molnar <mingo@...e.hu>
To: linux-kernel@...r.kernel.org, Len Brown <lenb@...nel.org>,
Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Henrique de Moraes Holschuh <hmh@....eng.br>,
Lorne Applebaum <lorne.applebaum@...il.com>,
Matthew Garrett <mjg@...hat.com>
Subject: Re: -tip: origin tree build failure
* Ingo Molnar <mingo@...e.hu> wrote:
> Add a Kconfig dependency on SOUND to remedy this.
ok, that should have been CONFIG_SND. Updated patch below.
Ingo
------------------->
>From f9bf1de0fcb6dddf0145d472b13a21ab8e7723cd Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@...e.hu>
Date: Thu, 17 Dec 2009 07:08:12 +0100
Subject: [PATCH] acpi: Build CONFIG_SOUND=m build failure in CONFIG_THINKPAD_ACPI
-tip testing found that commit 0d204c34e85d1d63e5fdd3e3192747daf0ee7ec1
("thinkpad-acpi: basic ALSA mixer support (v2)") from today's upstream
kernel causes the following build failure on x86, for
CONFIG_THINKPAD_ACPI=y && CONFIG_SOUND=m:
drivers/built-in.o: In function `volume_alsa_notify_change':
thinkpad_acpi.c:(.text+0x2d5c2d): undefined reference to `snd_ctl_notify'
thinkpad_acpi.c:(.text+0x2d5c47): undefined reference to `snd_ctl_notify'
This build fails because thinkpad_acpi.c uses sound facilities
unconditionally, without expressing its dependency on the sound
subsystem.
Add a Kconfig dependency on SOUND to remedy this.
Cc: Len Brown <len.brown@...el.com>
Cc: Henrique de Moraes Holschuh <hmh@....eng.br>
Cc: Lorne Applebaum <lorne.applebaum@...il.com>
Cc: Matthew Garrett <mjg@...hat.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
drivers/platform/x86/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index f8bec62..dbd4ef1 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -216,6 +216,7 @@ config THINKPAD_ACPI
depends on ACPI
depends on INPUT
depends on RFKILL || RFKILL = n
+ depends on SND
select BACKLIGHT_LCD_SUPPORT
select BACKLIGHT_CLASS_DEVICE
select HWMON
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists