[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20091217142334.10948.47866.stgit@beardog.cce.hp.com>
Date: Thu, 17 Dec 2009 08:23:34 -0600
From: "Stephen M. Cameron" <scameron@...rdog.cce.hp.com>
To: axboe@...nel.dk, James.Bottomley@...senPartnership.com,
akpm@...ux-foundation.org
Cc: linux-kernel@...r.kernel.org, mikem@...rdog.cce.hp.com,
linux-scsi@...r.kernel.org, smcameron@...oo.com
Subject: [PATCH] hpsa: fix scsi status reporting yet again.
From: Stephen M. Cameron <scameron@...rdog.cce.hp.com>
hpsa: fix scsi status reporting yet again, reverting an earlier
attempt. The status byte does not need to be shifted << 1. Code
in other drivers that does "scp->result |= CHECK_CONDITION << 1;"
works because CHECK_CONDITION macro is pre-shifted right 1 bit.
Signed-off-by: Stephen M. Cameron <scameron@...rdog.cce.hp.com>
---
drivers/scsi/hpsa.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 22bca00..1f4dd27 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -930,7 +930,7 @@ static void complete_scsi_command(struct CommandList *cp,
cmd->result = (DID_OK << 16); /* host byte */
cmd->result |= (COMMAND_COMPLETE << 8); /* msg byte */
- cmd->result |= (ei->ScsiStatus << 1);
+ cmd->result |= ei->ScsiStatus;
/* copy the sense data whether we need to or not. */
memcpy(cmd->sense_buffer, ei->SenseInfo,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists