linux-kernel - Re: [lm-sensors] [PATCH] adt7462: Fix pin 28 monitoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091217161009.3a3a106f@hyperion.delvare>
Date:	Thu, 17 Dec 2009 16:10:09 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	roger blofeld <blofeldus@...oo.com>
Cc:	"Darrick J. Wong" <djwong@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>, lm-sensors@...sensors.org
Subject: Re: [lm-sensors] [PATCH] adt7462: Fix pin 28 monitoring

Hi Roger,

On Fri, 11 Dec 2009 18:54:54 -0800 (PST), roger blofeld wrote:
> The ADT7462_PIN28_VOLT value is a 4-bit field, so the corresponding shift must be 4.
> 
> Signed-off-by: Roger Blofeld <blofeldus@...oo.com>
> ---
> My mailer will whitespace damage the inline copy of the patch.
> The attached version should be OK.
> 
> diff --git a/drivers/hwmon/adt7462.c b/drivers/hwmon/adt7462.c
> index 1852f27..262c133 100644
> --- a/drivers/hwmon/adt7462.c
> +++ b/drivers/hwmon/adt7462.c
> @@ -97,7 +97,7 @@ I2C_CLIENT_INSMOD_1(adt7462);
>  #define        ADT7462_PIN24_SHIFT        6
>  #define        ADT7462_PIN26_VOLT_INPUT    0x08
>  #define        ADT7462_PIN25_VOLT_INPUT    0x20
> -#define        ADT7462_PIN28_SHIFT        6    /* cfg3 */
> +#define        ADT7462_PIN28_SHIFT        4    /* cfg3 */
>  #define        ADT7462_PIN28_VOLT        0x5
>  
>  #define ADT7462_REG_ALARM1            0xB8

Correct. Applied, thanks.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/