linux-kernel - Re: [PATCH] spi: xilinx_spi: Fix up I/O routine wrapping bogosity.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa686aa40912170901p6af26715l5f009ba96d1e1341@mail.gmail.com>
Date:	Thu, 17 Dec 2009 09:01:25 -0800
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Paul Mundt <lethal@...ux-sh.org>
Cc:	John Linn <John.Linn@...inx.com>, richard.rojfors@...ean-labs.com,
	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: xilinx_spi: Fix up I/O routine wrapping bogosity.

On Tue, Dec 15, 2009 at 10:01 PM, Paul Mundt <lethal@...ux-sh.org> wrote:
> xilinx_spi presently makes some fairly questionable assumptions about I/O
> routines, and attempts to assign ioread32/iowrite32 and friends directly
> to its own internal function pointers. On many platforms these I/O
> routines are macros or wrappers and not actual functions on their own,
> resulting in things like:
>
> ERROR: "ioread32be" [drivers/spi/xilinx_spi.ko] undefined!
> ERROR: "iowrite32be" [drivers/spi/xilinx_spi.ko] undefined!
> ERROR: "iowrite32" [drivers/spi/xilinx_spi.ko] undefined!
> ERROR: "ioread32" [drivers/spi/xilinx_spi.ko] undefined!

Unfortunately, ARM doesn't have either ioread32be or iowrite32be
defined, so the problem is still not solved with this patch.  I've
crafted a patch to add them which I'll send to the ARM list right now.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/