linux-kernel - [RFC 0/6] Driver core: Encourage use of const attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1261073536-27396-1-git-send-email-ext-phil.2.carmody@nokia.com>
Date:	Thu, 17 Dec 2009 20:12:10 +0200
From:	Phil Carmody <ext-phil.2.carmody@...ia.com>
To:	gregkh@...e.de
Cc:	linux-kernel@...r.kernel.org
Subject: [RFC 0/6] Driver core: Encourage use of const attributes

I know now's probably a bad time to be mentioning const issues
but I recently a reviewed a patch where 'const' was being removed 
from a device_attribute structure, and I enquired why. The reason
was simply so that device_create_file() could be called, it taking
a non-const attribute pointer. Looking inside, all that function 
did was pass a pointer to sysfs_create_file, which itself took a
const pointer. Non-constness was not required at all.

So here I offer a small patchset which I hope will permit and 
encourage device and other attributes to be made const, and put 
in read-only sections.

1-3 address the three attribute types which seemed to be trivially 
const-able, and are the important part of the set.

4 adds a new macro to encourage the use of Const ATTRibutes,
and may need a better name. (I wanted to avoid RO, for example.)

5 and 6 are merely two quick examples of how easy it is to adopt 
the new const convention. In reality, these structures have been
constant and treated as constant by the driver core all along, it's
just that one word was missing from a few important places.

I would hope to submit a patchset with 1-3 and a possibly modified 
4. The migrations themselves will belong in different trees.

These have been compile/sparse tested against arm and x86_64 targets, 
and through my usual suite of tests on the arm platform I use.

Regards,
Phil

Phil Carmody (6):
  Driver core: device_attribute parameters can often be const*
  Driver core: bin_attribute parameters can often be const*
  Driver core: driver_attribute parameters can often be const*
  Driver core: Easy macros to encourage const attributes
  PM: Example of how easy it is to mark attributes const
  gpio: Example of how easy it is to mark attributes const

 drivers/base/core.c      |   12 ++++++++----
 drivers/base/driver.c    |    4 ++--
 drivers/gpio/gpiolib.c   |   12 ++++++------
 drivers/regulator/core.c |   38 +++++++++++++++++++-------------------
 fs/sysfs/bin.c           |    6 ++++--
 include/linux/device.h   |   20 ++++++++++++++------
 include/linux/sysfs.h    |    9 +++++----
 7 files changed, 58 insertions(+), 43 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/