linux-kernel - Re: [tip:x86/urgent] Makefile: set LC_CTYPE, LC_COLLATE, LC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091217220951.GB4236@merkur.ravnborg.org>
Date:	Thu, 17 Dec 2009 23:09:51 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	rdreier@...co.com, mmarek@...e.cz, tglx@...utronix.de,
	mhiramat@...hat.com
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/urgent] Makefile: set LC_CTYPE, LC_COLLATE,
	LC_NUMERIC to C

On Thu, Dec 17, 2009 at 04:18:35PM +0000, tip-bot for H. Peter Anvin wrote:
> Commit-ID:  c051346b7db27aaf674b8f3b4955240580b2a58a
> Gitweb:     http://git.kernel.org/tip/c051346b7db27aaf674b8f3b4955240580b2a58a
> Author:     H. Peter Anvin <hpa@...or.com>
> AuthorDate: Thu, 17 Dec 2009 06:56:11 -0800
> Committer:  H. Peter Anvin <hpa@...or.com>
> CommitDate: Thu, 17 Dec 2009 07:03:21 -0800
> 
> Makefile: set LC_CTYPE, LC_COLLATE, LC_NUMERIC to C
> 
> There are a number of common Unix constructs like character ranges in
> grep/sed/awk which don't work as expected with LC_COLLATE set to other
> than C.  Similarly, set LC_CTYPE and LC_NUMERIC to C to avoid other
> nasty surprises.
> 
> In order to make sure these actually take effect we also have to
> clear LC_ALL.
> 
> Signed-off-by: H. Peter Anvin <hpa@...or.com>
> Acked-by: Michal Marek <mmarek@...s.cz>
> Acked-by: Masami Hiramatsu <mhiramat@...hat.com>
> Acked-by: Roland Dreier <rdreier@...co.com>
> Cc: Sam Ravnborg <sam@...nborg.org>
> LKML-Reference: <4B2A1761.4070904@...e.cz>

This is IMO -next fodder and not urgent stuff.
In the distant past something similar caused us troubles.

I assume that the patch posted by Roland fixes
the relevant troubles with the awk script and that
this patch is just for consistency.
So in other words stuff for -next and not -rc1.

Anyway - just MHO.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/