linux-kernel - Re: [Patch] thinkpad_acpi: fix a build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B2B743B.7010004@gmail.com>
Date:	Fri, 18 Dec 2009 20:23:23 +0800
From:	"Helight.Xu" <helight.xu@...il.com>
To:	Takashi Iwai <tiwai@...e.de>
CC:	Xiaotian Feng <xtfeng@...il.com>, Amerigo Wang <amwang@...hat.com>,
	linux-kernel@...r.kernel.org,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	Corentin Chary <corentincj@...aif.net>,
	ibm-acpi-devel@...ts.sourceforge.net,
	Len Brown <len.brown@...el.com>,
	Alan Jenkins <alan-jenkins@...fmail.co.uk>,
	akpm@...ux-foundation.org
Subject: Re: [Patch] thinkpad_acpi: fix a build error

Takashi Iwai wrote:
> At Fri, 18 Dec 2009 17:42:34 +0800,
> Xiaotian Feng wrote:
>   
>> Ingo already sent this patch yesterday.
>> http://lkml.org/lkml/2009/12/17/25
>>
>>
>> On Fri, Dec 18, 2009 at 5:28 PM, Amerigo Wang <amwang@...hat.com> wrote:
>>     
>>> This patch fixes the following build error:
>>>
>>>  Building modules, stage 2.
>>>  MODPOST 1834 modules
>>> ERROR: "snd_card_create" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
>>> ERROR: "snd_ctl_notify" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
>>> ERROR: "snd_ctl_boolean_mono_info" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
>>> ERROR: "snd_ctl_new1" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
>>> ERROR: "snd_card_free" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
>>> ERROR: "snd_card_register" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
>>> ERROR: "snd_ctl_add" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
>>>
>>> Cc: Len Brown <len.brown@...el.com>
>>> Cc: Corentin Chary <corentincj@...aif.net>
>>> Cc: Henrique de Moraes Holschuh <hmh@....eng.br>
>>> Cc: Alan Jenkins <alan-jenkins@...fmail.co.uk>
>>> Reported-by: Helight.Xu <helight.xu@...il.com>
>>> Signed-off-by: WANG Cong <amwang@...hat.com>
>>> Tested-by: Helight.Xu <helight.xu@...il.com>
>>>
>>> ---
>>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>>> index fc5bf9d..596966c 100644
>>> --- a/drivers/platform/x86/Kconfig
>>> +++ b/drivers/platform/x86/Kconfig
>>> @@ -215,6 +215,7 @@ config THINKPAD_ACPI
>>>        depends on ACPI
>>>        depends on INPUT
>>>        depends on RFKILL || RFKILL = n
>>> +       depends on SOUND
>>>       
>
> The patch isn't correct (I guess the upstream fix is same?).
>
> CONFIG_SOUND is a global config for sound subsystem.  The relevant
> functions are ALSA core part, which is CONFIG_SND.
> So, the fix should be:
>
> 	depends on SND
>   
yes, I think so ! It should be "depends on SND", and I am testing now!
> instead.
>
>
> Takashi
>
>   


-- 
Zhenwen Xu - Seven Helight
Home Page: http://zhwen.org

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/