linux-kernel - Re: [PATCH] Drop 80-character limit in checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.0912181400130.21496@twin.jikos.cz>
Date:	Fri, 18 Dec 2009 14:04:37 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Américo Wang <xiyou.wangcong@...il.com>,
	Mikulas Patocka <mpatocka@...hat.com>,
	linux-kernel@...r.kernel.org, Alasdair G Kergon <agk@...hat.com>,
	dm-devel@...hat.com
Subject: Re: [PATCH] Drop 80-character limit in checkpatch.pl

On Thu, 17 Dec 2009, Bartlomiej Zolnierkiewicz wrote:

> > > I like this patch, this is actually what I wanted to do.
> > 
> > I have nothing against a switch, but it had better default to off.
> > 
> > The whole 80-char limit is insane. It results in insane "fixes". Just 
> > about every time somebody "improves" a patch due to the warning, the 
> > result is worse than the original patch.
> 
> Examples? :)

balance_leaf() in fs/reiserfs/do_balan.c

Example picked totally at random:

	set_le_ih_k_offset(ih,
			   le_ih_k_offset(ih) +
			   (tb->
			    lbytes <<
			    (is_indirect_le_ih
			     (ih) ? tb->tb_sb->
			     s_blocksize_bits -
			     UNFM_P_SHIFT :
			     0)));

See how everything is nicely aligned to 80 cols?


Generally, don't look at this function after having a good lunch you want 
to keep. You have been warned.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/