[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <s5h4ono73qx.wl%tiwai@suse.de>
Date: Fri, 18 Dec 2009 15:31:34 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Henrique de Moraes Holschuh <hmh@....eng.br>
Cc: Xiaotian Feng <xtfeng@...il.com>, Amerigo Wang <amwang@...hat.com>,
linux-kernel@...r.kernel.org,
Corentin Chary <corentincj@...aif.net>,
ibm-acpi-devel@...ts.sourceforge.net,
Len Brown <len.brown@...el.com>,
Alan Jenkins <alan-jenkins@...fmail.co.uk>,
akpm@...ux-foundation.org, helight.xu@...il.com
Subject: Re: [Patch] thinkpad_acpi: fix a build error
At Fri, 18 Dec 2009 12:28:15 -0200,
Henrique de Moraes Holschuh wrote:
>
> On Fri, 18 Dec 2009, Takashi Iwai wrote:
> > The patch isn't correct (I guess the upstream fix is same?).
> >
> > CONFIG_SOUND is a global config for sound subsystem. The relevant
> > functions are ALSA core part, which is CONFIG_SND.
> > So, the fix should be:
> >
> > depends on SND
> >
> > instead.
>
> Indeed. Ingo already fixed that too.
>
> Although I personally would prefer:
> select SOUND
> select SND
SND already depends on SOUND, so it's just superfluous.
Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists