linux-kernel - Re: [PATCH] Drop 80-character limit in checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200912181611.50871.bzolnier@gmail.com>
Date:	Fri, 18 Dec 2009 16:11:50 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Krzysztof Halasa <khc@...waw.pl>
Cc:	Valdis.Kletnieks@...edu, Mikulas Patocka <mpatocka@...hat.com>,
	Paul Mundt <lethal@...ux-sh.org>, linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Alasdair G Kergon <agk@...hat.com>, dm-devel@...hat.com
Subject: Re: [PATCH] Drop 80-character limit in checkpatch.pl

On Friday 18 December 2009 03:28:12 pm Krzysztof Halasa wrote:
> Valdis.Kletnieks@...edu writes:
> 
> > Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non-
> > continuation line, it's probably in its rights to whinge.
> 
> Yes, but don't make it a hard error, only a suggestion that something is
> probably really wrong.
> 
> > fs/reisersfs/do_balan.c, lines 460-477 (note: 3 leading tabs elided)
> >
> > 				leaf_paste_entries(&bi,
> > 						   n +
> > 						   item_pos
> > 						   -
> > 						   ret_val,
> > 						   l_pos_in_item,
> > 						   1,
> > 						   (struct
> > 						    reiserfs_de_head
> > 						    *)
> > 						   body,
> > 						   body
> > 						   +
> > 						   DEH_SIZE,
> > 						   tb->
> > 						   insert_size
> > 						   [0]
> > 				    );
> >
> > Yes, that used to be 24 more columns to the right.  Gaak.
> 
> Precisely. It's a clear show of the damage hard rules like that do.

It is not a hard rule and the above damage was done in 2005 when some
random developer (Linus Torvalds?  Is this even a real name? ;-) decided
to mindlessly pass do_balan.c file through Lindent script and later
didn't finish the task of cleaning the code properly (see commit bd4c625
for details).

We didn't even have checkpatch.pl back then (it was added in 2007).

> I can't even tell how the code should be fixed and if the simple merging
> would do, since I can't really imagine how it would look like :-)

The old code [ no tabs removed ]:

-                           leaf_paste_entries (bi.bi_bh, n + item_pos - ret_val, l_pos_in_item, 1,
-                                               (struct reiserfs_de_head *)body,
-                                               body + DEH_SIZE, tb->insert_size[0]
-                               );

--
Bartlomiej Zolnierkiewicz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/