linux-kernel - Re: [PATCH] Drop 80-character limit in checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Dec 2009 09:28:21 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mikulas Patocka <mpatocka@...hat.com>
cc:	kevin granade <kevin.granade@...il.com>,
	Krzysztof Halasa <khc@...waw.pl>, Valdis.Kletnieks@...edu,
	Paul Mundt <lethal@...ux-sh.org>, linux-kernel@...r.kernel.org,
	Alasdair G Kergon <agk@...hat.com>, dm-devel@...hat.com
Subject: Re: [PATCH] Drop 80-character limit in checkpatch.pl

On Fri, 18 Dec 2009, Mikulas Patocka wrote:
> 
> Function declarations are often larger than 80 characters. And if you wrap 
> them at 100, you are wasting every second line on 80-character display.

If you care so much, use a non-wrapping editor. That's what I do.

> If you make line length unlimited, the space will be used optimally on all 
> displays --- a function with 200 character declaration will use 3 lines on 
> 80-character display and 2 lines on 100-character display.

Yeah, and that's just crazy.

We all use good hardware these days, but we certainly don't have unlimited 
line length. And wrapping is ugly. So sane people (definition: "me") use 
editors that don't wrap (marking long lines at the end instead), and for 
the very rare case when I use a small terminal, I'll need to go look if I 
care (which is seldom).

> And besides --- wrapping at 100 doesn't fix the initial problem (why I 
> posted this thread) --- that making any modification to the function 
> header or long expression requires the user to manually realign the 
> arguments.

Sure. Nothing fixes the problem that you need to _occasionally_ wrap.

But the real problem is that crazy people consider checkpatch.pl to be so 
important that they wrap whether it makes sense or not.

Sense. It's what some people have. Too rare, though.

I'll happily remove the checkpatch.pl limit entirely, and ask people to 
try to use common sense, though.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/