linux-kernel - Re: [GIT PULL] omap build fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B2AADCD.4080802@blueyonder.co.uk>
Date:	Thu, 17 Dec 2009 22:16:45 +0000
From:	Sid Boyce <sboyce@...eyonder.co.uk>
To:	Tony Lindgren <tony@...mide.com>
CC:	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [GIT PULL] omap build fixes

On 17/12/09 17:26, Tony Lindgren wrote:
> * Sid Boyce <sboyce@...eyonder.co.uk> [091217 03:29]:
> 
> <snip>
>  
>> uImage built, so EHCI build problem definitely fixed, just one error
>> I've previously encountered when building modules.
>> slipstream:/home/lancelot/ftp/dec09/OMAP/omap-fixes-for-linus # ARCH=arm
>> make -j 4 CROSS_COMPILE=/opt/arm-2009q3/bin/arm-none-eabi- modules
>> scripts/kconfig/conf -s arch/arm/Kconfig
>>   CHK     include/linux/version.h
>>   SYMLINK include/asm -> include/asm-arm
>> make[1]: `include/asm-arm/mach-types.h' is up to date.
>>   CHK     include/linux/utsrelease.h
>>   CALL    scripts/checksyscalls.sh
>> <stdin>:1523: warning: #warning syscall recvmmsg not implemented
>>   Building modules, stage 2.
>>   MODPOST 99 modules
>> ERROR: "omap_ctrl_writel" [sound/soc/omap/snd-soc-omap-mcbsp.ko] undefined!
>> ERROR: "omap_ctrl_readl" [sound/soc/omap/snd-soc-omap-mcbsp.ko] undefined!
>> make[1]: *** [__modpost] Error 1
>> make: *** [modules] Error 2
> 
> Hmm. I'm not seeing this in any of the defconfigs, so I guess this
> happens with ASoC complied as a module.
> 
> But instead of exporting omap_ctrl_read/write, we need to get rid of 
> omap_ctrl_read/write stuff in the drivers.
> 
> It seems that omap_mcbsp_dai_set_clks_src() should be implemented in
> the clock framework instead.
> 
> Regards,
> 
> Tony
> 
> 

Confirmed it works when compiled in.
Regards
Sid.

-- 
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot
Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support
Specialist, Cricket Coach
Microsoft Windows Free Zone - Linux used for all Computing Tasks

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/