[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <24653.1261110557@localhost>
Date: Thu, 17 Dec 2009 23:29:17 -0500
From: Valdis.Kletnieks@...edu
To: Mikulas Patocka <mpatocka@...hat.com>
Cc: Krzysztof Halasa <khc@...waw.pl>, Paul Mundt <lethal@...ux-sh.org>,
linux-kernel@...r.kernel.org,
Linus Torvalds <torvalds@...ux-foundation.org>,
Alasdair G Kergon <agk@...hat.com>, dm-devel@...hat.com
Subject: Re: [PATCH] Drop 80-character limit in checkpatch.pl
On Thu, 17 Dec 2009 18:29:25 EST, Mikulas Patocka said:
> There is no need to make a script for it. The script isn't so smart to
> tell what is understandable and what is nto.
Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non-
continuation line, it's probably in its rights to whinge.
grep -r -P '^\t{7}(?!(.*,$|.*\);$))' . | more
produces a whole lot of "this can't end well" output. My favorite so far:
fs/reisersfs/do_balan.c, lines 460-477 (note: 3 leading tabs elided)
leaf_paste_entries(&bi,
n +
item_pos
-
ret_val,
l_pos_in_item,
1,
(struct
reiserfs_de_head
*)
body,
body
+
DEH_SIZE,
tb->
insert_size
[0]
);
Yes, that used to be 24 more columns to the right. Gaak.
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists