linux-kernel - Re: [PATCH 4/7] can/at91: don't check platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091218.203209.229747361.davem@davemloft.net>
Date:	Fri, 18 Dec 2009 20:32:09 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	wg@...ndegger.com
Cc:	u.kleine-koenig@...gutronix.de, linux-kernel@...r.kernel.org,
	dvrabel@...om.com, gregkh@...e.de, urs.thuermann@...kswagen.de,
	oliver.hartkopp@...kswagen.de, kurt.van.dijck@....be,
	netdev@...r.kernel.org
Subject: Re: [PATCH 4/7] can/at91: don't check platform_get_irq's return
 value against zero

From: Wolfgang Grandegger <wg@...ndegger.com>
Date: Wed, 16 Dec 2009 19:58:38 +0100

> Uwe Kleine-König wrote:
>> platform_get_irq returns -ENXIO on failure, so !irq was probably
>> always true.  Better use (int)irq <= 0.  Note that a return value of
>> zero is still handled as error even though this could mean irq0.
>> 
>> This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
>> changed the return value of platform_get_irq from 0 to -ENXIO on error.
>> 
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> Signed-off-by: Wolfgang Grandegger <wg@...ndegger.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/