lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 19 Dec 2009 09:40:55 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Julia Lawall <julia@...u.dk>
Cc:	Jaroslav Kysela <perex@...ex.cz>, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 7/7] sound: Use kzalloc for allocating only one thing

At Sat, 19 Dec 2009 08:18:03 +0100 (CET),
Julia Lawall wrote:
> 
> From: Julia Lawall <julia@...u.dk>
> 
> Use kzalloc rather than kcalloc(1,...)
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> @@
> 
> - kcalloc(1,
> + kzalloc(
>           ...)
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>

Applied now.  Thanks.


Takashi

> 
> ---
>  sound/isa/msnd/msnd_midi.c    |    2 +-
>  sound/pci/hda/patch_realtek.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff -u -p a/sound/isa/msnd/msnd_midi.c b/sound/isa/msnd/msnd_midi.c
> --- a/sound/isa/msnd/msnd_midi.c 2009-03-28 23:34:55.000000000 +0100
> +++ b/sound/isa/msnd/msnd_midi.c 2009-12-19 07:52:27.000000000 +0100
> @@ -162,7 +162,7 @@ int snd_msndmidi_new(struct snd_card *ca
>  	err = snd_rawmidi_new(card, "MSND-MIDI", device, 1, 1, &rmidi);
>  	if (err < 0)
>  		return err;
> -	mpu = kcalloc(1, sizeof(*mpu), GFP_KERNEL);
> +	mpu = kzalloc(sizeof(*mpu), GFP_KERNEL);
>  	if (mpu == NULL) {
>  		snd_device_free(card, rmidi);
>  		return -ENOMEM;
> diff -u -p a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> --- a/sound/pci/hda/patch_realtek.c 2009-12-17 08:30:15.000000000 +0100
> +++ b/sound/pci/hda/patch_realtek.c 2009-12-19 07:52:50.000000000 +0100
> @@ -12857,7 +12857,7 @@ static int patch_alc268(struct hda_codec
>  	int board_config;
>  	int i, has_beep, err;
>  
> -	spec = kcalloc(1, sizeof(*spec), GFP_KERNEL);
> +	spec = kzalloc(sizeof(*spec), GFP_KERNEL);
>  	if (spec == NULL)
>  		return -ENOMEM;
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists