linux-kernel - [PATCH] scripts/checkpatch.pl: Add WARN on printk format split on multiple lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1261338255.30458.222.camel@Joe-Laptop.home>
Date:	Sun, 20 Dec 2009 11:44:15 -0800
From:	Joe Perches <joe@...ches.com>
To:	Ingo Molnar <mingo@...e.hu>, Andy Whitcroft <apw@...onical.com>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, peterz@...radead.org, efault@....de,
	akpm@...ux-foundation.org, tglx@...utronix.de
Subject: [PATCH] scripts/checkpatch.pl: Add WARN on printk format split on
 multiple lines

On Sun, 2009-12-20 at 20:15 +0100, Ingo Molnar wrote:
> Checkpatch should warn about printk 
> lines that end with a '"', those are almost always a sign of some ill-advised 
> break-the-string artifact.

Perhaps something like this:

diff from Andy Whitcroft's testing script,
where logFunctions is defined.
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing

--- a/scripts/checkpatch.pl-testing	2009-12-20 11:35:28.000000000 -0800
+++ b/scripts/checkpatch.pl-testing	2009-12-20 11:35:46.000000000 -0800
@@ -1398,6 +1398,11 @@
 			WARN("line over 80 characters\n" . $herecurr);
 		}
 
+#Logging function format split over multiple lines
+		if ($line =~ /^\+\s*$logFunctions.*"\s*$/) {
+			WARN("Don't split logging function format\n" . $herecurr);
+		}
+
 # check for adding lines without a newline.
 		if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
 			WARN("adding a line without newline at end of file\n" . $herecurr);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/