| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20091220221232.GC4887@thunk.org> Date: Sun, 20 Dec 2009 17:12:32 -0500 From: tytso@....edu To: Ingo Molnar <mingo@...e.hu> Cc: Joe Perches <joe@...ches.com>, mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org, peterz@...radead.org, efault@....de, akpm@...ux-foundation.org, tglx@...utronix.de, linux-tip-commits@...r.kernel.org Subject: Re: [tip:sched/urgent] sched: Restore printk sanity On Sun, Dec 20, 2009 at 08:15:31PM +0100, Ingo Molnar wrote: > > It's also needlessly broken mid-string. Checkpatch should warn about printk > lines that end with a '"', those are almost always a sign of some ill-advised > break-the-string artifact. Ironic, given that for a long time checkpatch strongly encouraged people to do this with its "line too long" complaint. Maybe all printk's should be exempted from this, or at least if it's the format string which is breaking whatever the magic boundary happens to be? Even if we up the limit to 106, or 132, or whatever, I can imagine situations where it will be *impossible* to shut up checkpatch. Either it will bitch and moan about the line being too long, or it will bitch and moan that a format string has been broken across multiple lines. :-( - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists