linux-kernel - Re: [uml-devel] linux-2.6.32 uml Segmentation fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <10f740e80912200107v4ffeee81k77e291ffaebac837@mail.gmail.com>
Date:	Sun, 20 Dec 2009 10:07:03 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	clownix <clownix@...wnix.net>, David Howells <dhowells@...hat.com>,
	James Morris <jmorris@...ei.org>, stable <stable@...nel.org>
Cc:	uml-devel <user-mode-linux-devel@...ts.sourceforge.net>,
	uml-user <user-mode-linux-user@...ts.sourceforge.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [uml-devel] linux-2.6.32 uml Segmentation fault

On Sat, Dec 19, 2009 at 12:33, clownix <clownix@...wnix.net> wrote:
> Hello
> For the 2.6.32 kernel there are 2 problems:
>
> 1: Compile error, this patch works for it:
> --------------------------------------------
>
> diff -Naur old_linux-2.6.32.1/security/keys/keyctl.c
> linux-2.6.32.1/security/keys/keyctl.c
> --- old_linux-2.6.32.1/security/keys/keyctl.c   2009-12-14
> 18:47:25.000000000 +0100
> +++ linux-2.6.32.1/security/keys/keyctl.c       2009-12-15 22:40:32.565286766
> +0100
> @@ -1236,6 +1236,7 @@
>  */
>  long keyctl_session_to_parent(void)
>  {
> +#ifdef TIF_NOTIFY_RESUME
>        struct task_struct *me, *parent;
>        const struct cred *mycred, *pcred;
>        struct cred *cred, *oldcred;
> @@ -1326,6 +1327,9 @@
>  error_keyring:
>        key_ref_put(keyring_r);
>        return ret;
> +#else /* !TIF_NOTIFY_RESUME */
> +       return -EOPNOTSUPP;
> +#endif /* !TIF_NOTIFY_RESUME */
>  }

Aha, UML is also affected.

Commit a00ae4d21b2fa9379914f270ffffd8d3bec55430 ("Keys:
KEYCTL_SESSION_TO_PARENT needs TIF_NOTIFY_RESUME architecture
support") should be in 2.6.32-stable as it fixes a regression, but
apparently the `Cc: stable@...nel.org' got lost?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/