linux-kernel - Re: [PATCH] Fix BUILD_BUG_ON in fs/compat_ioctl.c to build with gcc 4.5 snapshot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091221105138.GD25372@basil.fritz.box>
Date:	Mon, 21 Dec 2009 11:51:39 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Andi Kleen <andi@...stfloor.org>, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, jbeulich@...ell.com,
	rguenther@...e.de, arnd@...db.de
Subject: Re: [PATCH] Fix BUILD_BUG_ON in fs/compat_ioctl.c to build with
	gcc 4.5 snapshot

On Mon, Dec 21, 2009 at 09:02:39PM +1030, Rusty Russell wrote:
> On Mon, 21 Dec 2009 03:23:15 am Andi Kleen wrote:
> > Fix BUILD_BUG_ON in fs/compat_ioctl.c to build with gcc 4.5 snapshot
> > 
> > The BUILD_BUG_ON in compat_ioctl_check_table() fails
> > with a recent gcc mainline snapshot (gcc version 4.5.0 20091219)
> > (GCC)), even though it works with older compilers.
> 
> We have a proper fix for BUILD_BUG_ON which I sent Linus a pull req for,
> but I think it was too late:
> 
> 	git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus.git BUILD_BUG_ON
> 
> It's not really high priority, but it'd be nice to fix this properly.

AFAIK the code I fixed was not correct in the first place because
"const int xxx" is not a constant expression in the standards sense.

So it's orthogonal to whatever changes you come up.

Building on gcc 4.5 is at least medium priority I would say.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/