linux-kernel - [PATCHv2 08/12]posix_acl: Add the check items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4B2F631F.4070303@gmail.com>
Date:	Mon, 21 Dec 2009 19:59:27 +0800
From:	Liuwenyi <qingshenlwy@...il.com>
To:	dwmw2@...radead.org, viro@...iv.linux.org.uk, jmorris@...ei.org,
	akpm@...ux-foundation.org, joel.becker@...cle.com,
	serue@...ibm.com, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org, onlyflyer@...il.com,
	strongzgy@...il.com
Subject: [PATCHv2 08/12]posix_acl: Add the check items

move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.

---
Signed-off-by: Liuwenyi <qingshenlwy@...il.com>
Cc: David Woodhouse <dwmw2@...radead.org>
Cc: Al Viro <viro@...iv.linux.org.uk>
Cc: James Morris <jmorris@...ei.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Joel Becker <joel.becker@...cle.com>
Cc: Serge Hallyn <serue@...ibm.com>
Cc: linux-mtd@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org

---
diff --git a/fs/jffs2/acl.c b/fs/jffs2/acl.c
index 7cdc319..1eb4726 100644
--- a/fs/jffs2/acl.c
+++ b/fs/jffs2/acl.c
@@ -403,13 +403,10 @@ static int jffs2_acl_setxattr(struct dentry
*dentry, const char *name,

if (value) {
acl = posix_acl_from_xattr(value, size);
- if (IS_ERR(acl))
- return PTR_ERR(acl);
- if (acl) {
- rc = posix_acl_valid(acl);
- if (rc)
- goto out;
- }
+ rc = posix_acl_valid(acl);
+ if (rc)
+ goto out;
+
} else {
acl = NULL;
}

-- 
Best Regards,
Liuwenyi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/