linux-kernel - [PATCHv2 10/12]posix_acl: Add the check items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4B2F637C.2080506@gmail.com>
Date:	Mon, 21 Dec 2009 20:01:00 +0800
From:	Liuwenyi <qingshenlwy@...il.com>
To:	mfasheh@...e.com, joel.becker@...cle.com, tiger.yang@...cle.com,
	viro@...iv.linux.org.uk, jmorris@...ei.org,
	ocfs2-devel@....oracle.com, linux-kernel@...r.kernel.org,
	strongzgy@...il.com, onlyflyer@...il.com
Subject: [PATCHv2 10/12]posix_acl: Add the check items

move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.

---
Signed-off-by: Liuwenyi <qingshenlwy@...il.com>
Cc: Mark Fasheh <mfasheh@...e.com>
Cc: Joel Becker <joel.becker@...cle.com>
Cc: Tiger Yang <tiger.yang@...cle.com>
Cc: Al Viro <viro@...iv.linux.org.uk>
Cc: James Morris <jmorris@...ei.org>
Cc: ocfs2-devel@....oracle.com
Cc: linux-kernel@...r.kernel.org

---
diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c
index e3e4741..b11c72c 100644
--- a/fs/ocfs2/acl.c
+++ b/fs/ocfs2/acl.c
@@ -408,13 +408,9 @@ static int ocfs2_xattr_set_acl(struct dentry
*dentry, const char *name,

if (value) {
acl = posix_acl_from_xattr(value, size);
- if (IS_ERR(acl))
- return PTR_ERR(acl);
- else if (acl) {
- ret = posix_acl_valid(acl);
- if (ret)
- goto cleanup;
- }
+ ret = posix_acl_valid(acl);
+ if (ret)
+ goto cleanup;
} else
acl = NULL;


-- 
Best Regards,
Liuwenyi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/