linux-kernel - Re: workqueue thing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Dec 2009 15:26:44 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Tejun Heo <tj@...nel.org>
Cc:	torvalds@...ux-foundation.org, awalls@...ix.net,
	linux-kernel@...r.kernel.org, jeff@...zik.org, mingo@...e.hu,
	akpm@...ux-foundation.org, jens.axboe@...cle.com,
	rusty@...tcorp.com.au, cl@...ux-foundation.org,
	dhowells@...hat.com, arjan@...ux.intel.com, avi@...hat.com,
	johannes@...solutions.net, andi@...stfloor.org
Subject: Re: workqueue thing

On Mon, 2009-12-21 at 22:30 +0900, Tejun Heo wrote:

> I think you're primarily concerned with the scheduler modifications

No I think the whole wq redesign sucks chunks, because it:

 1) looses the queue property
 2) doesn't deal with cpu heavy tasks/wakeup parallelism
 3) gets fragile at memory-pressure/reclaim
 4) didn't consider the RT needs

Also, I think that whole move tasks back on online stuff is utter crazy,
just move then to another cpu and leave them there.

Also, I don't think it can properly warn of simple AB-BA flush
deadlocks, where work A flushes B and B flushes A.

(I also don't much like the colour coding flush implementation, but I
haven't spend a lot of time considering alternatives)

> and think that the choose-between-two-masks on migration is ugly.  I
> agree it's not the prettiest thing in this world but then again it's
> not a lot of code.  The reason why it looks ugly is because the way
> migration is implemented and parameter is passed in.  API-wise, I
> think making kthread_bind() synchronized against cpu onliness should
> be pretty clean.

Assuming you only migrate blocked tasks the current kthread_bind()
should suit your needs -- I recently reworked most of the migration
logic.

But as it stands I don't think its wise to replace the current workqueue
implementation with this, esp since there are known heavy CPU users
using it, nor have you addressed the queueing issue (or is that the
restoration of the single-queue workqueue?)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/