linux-kernel - Re: BUG null dereference in driver ./drivers/usb/misc/sisusbvga/sisusb.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091221162048.GB7091@suse.de>
Date:	Mon, 21 Dec 2009 08:20:48 -0800
From:	Greg KH <gregkh@...e.de>
To:	Alexander Strakh <strakh@...ras.ru>
Cc:	Thomas Winischhofer <thomas@...ischhofer.net>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: BUG null dereference in driver
	./drivers/usb/misc/sisusbvga/sisusb.c

On Mon, Dec 21, 2009 at 08:03:10PM +0000, Alexander Strakh wrote:
>         KERNEL_VERSION: 2.6.32
>         SUBJECT: null derefernce in function sisusb_probe
>         SUBSCRIBE:
>         In driver drivers/usb/misc/sisusbvga/sisusb.c in function 
> sisusb_probe:
> 
> 1. if in line 3085 after calling function kzalloc variable sisub = 
> NULL, then we goto line 3086.
> 2. In line 3086:  null dereference of sisusb - "&sisusb->sisusb_dev->dev".
> 
> 3084         /* Allocate memory for our private */
> 3085         if (!(sisusb = kzalloc(sizeof(*sisusb), GFP_KERNEL))) {
> 3086                 dev_err(&sisusb->sisusb_dev->dev, "Failed to allocate 
> memory for private data\n");
> 3087                 return -ENOMEM;
> 3088         }
> 3089         kref_init(&sisusb->kref);

Good catch, care to send a patch?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/