linux-kernel - Re: [PATCH] fs/compat_ioctl.c: fix build error when !BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 21 Dec 2009 17:53:53 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Alexander Beregalov <a.beregalov@...il.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org,
	Randy Dunlap <randy.dunlap@...cle.com>
Subject: Re: [PATCH] fs/compat_ioctl.c: fix build error when !BLOCK

No driver uses SG_SET_TRANSFORM any more in Linux, since the ide-scsi
driver was removed in 2.6.29. The compat-ioctl cleanup series moved
the handling for this around, which broke building without CONFIG_BLOCK.

Just remove the code handling it for compat mode.
---

On Sunday 20 December 2009, Alexander Beregalov wrote:
> 2009/12/21 Al Viro <viro@...iv.linux.org.uk>:
> > On Mon, Dec 21, 2009 at 12:21:32AM +0300, Alexander Beregalov wrote:
> >> Fix this build error when CONFIG_BLOCK is not set.
> >> fs/compat_ioctl.c:1604: error: 'SG_SET_TRANSFORM' undeclared
> >
> > Do you want that through VFS tree?  I'm going to send a bunch of assorted
> > fixes tomorrow morning, so I can pass that one at the same time...
> 
> Yes, please.

Sorry for being slow on this, I already had the fix prepared when Randy
found it last week but had not gotten around to submitting it.

Al, the patch that Alexander has sent is obviously correct as well,
so if you have already prepared the series just keep that one, otherwise
please replace it with this one.

--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -1600,8 +1600,6 @@ static long do_ioctl_trans(int fd, unsigned int cmd,
 	case KDSKBMETA:
 	case KDSKBLED:
 	case KDSETLED:
-	/* SG stuff */
-	case SG_SET_TRANSFORM:
 	/* AUTOFS */
 	case AUTOFS_IOC_READY:
 	case AUTOFS_IOC_FAIL:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/