linux-kernel - Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not provably correct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B2FADC5.3020709@zytor.com>
Date:	Mon, 21 Dec 2009 09:17:57 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Arjan van de Ven <arjan@...radead.org>,
	Ritesh Raj Sarraf <rrs@...earchut.com>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not
 provably correct

On 12/21/2009 01:13 AM, Ingo Molnar wrote:
> 
> * KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:
> 
>>>                  from mm/migrate.c:15:
>>> In function ???copy_from_user???,
>>>     inlined from ???do_pages_stat??? at mm/migrate.c:1009:
>>> /tmp/all-yes-config/2.6.33-rc1/arch/x86/include/asm/uaccess_32.h:213: error: 
>>> call to ???copy_from_user_overflow??? declared with attribute error: 
>>> copy_from_user() buffer size is not provably correct
>>
>> afaik, ingo already queued this fix.
>> please wait (very) few days.
>>
>> thanks.
> 
> hm, the one mm/migrate.c fix we had is already in -rc1:
> 
>  b9255850: mm: Adjust do_pages_stat() so gcc can see copy_from_user() is safe
> 
> I've Cc:-ed more folks.
> 

That *is* the error report that he is describing.  What version of gcc
is he using?  It might be dumber than the one I have.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/