linux-kernel - Re: [PATCH 3/7] drivers/net/cxgb3: Use kzalloc for allocating only one thing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B3005D5.9070608@chelsio.com>
Date:	Mon, 21 Dec 2009 15:33:41 -0800
From:	Divy Le Ray <divy@...lsio.com>
To:	Julia Lawall <julia@...u.dk>
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/7] drivers/net/cxgb3: Use kzalloc for allocating only
 one thing

Julia Lawall wrote:
>
> From: Julia Lawall <julia@...u.dk>
>
> Use kzalloc rather than kcalloc(1,...)
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> @@
>
> - kcalloc(1,
> + kzalloc(
>           ...)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@...u.dk>
>

Acked-by: Divy Le Ray <divy@...lsio.com>

>
> ---
>  drivers/net/cxgb3/cxgb3_offload.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -u -p a/drivers/net/cxgb3/cxgb3_offload.c 
> b/drivers/net/cxgb3/cxgb3_offload.c
> --- a/drivers/net/cxgb3/cxgb3_offload.c 2009-09-14 14:55:49.000000000 
> +0200
> +++ b/drivers/net/cxgb3/cxgb3_offload.c 2009-12-19 07:52:52.000000000 
> +0100
> @@ -1252,7 +1252,7 @@ int cxgb3_offload_activate(struct adapte
>         struct mtutab mtutab;
>         unsigned int l2t_capacity;
>
> -       t = kcalloc(1, sizeof(*t), GFP_KERNEL);
> +       t = kzalloc(sizeof(*t), GFP_KERNEL);
>         if (!t)
>                 return -ENOMEM;
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/