linux-kernel - Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not provably correct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091221091330.GA22867@elte.hu>
Date:	Mon, 21 Dec 2009 10:13:30 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Arjan van de Ven <arjan@...radead.org>,
	"H. Peter Anvin" <hpa@...or.com>
Cc:	Ritesh Raj Sarraf <rrs@...earchut.com>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not
 provably correct


* KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:

> > This is triggered if using the 'allyesconfig' target.
> > 
> > A similar issue was this: 2886a8bdfa007053b414ab01741a98c18c376a85
> > 
> > 
> > debian-build:/tmp/all-yes-config/2.6.33-rc1# make deb-pkg
> > make KBUILD_SRC=                                         
> >   CHK     include/linux/version.h                        
> >   CHK     include/generated/utsrelease.h                 
> >   CALL    scripts/checksyscalls.sh                       
> >   CHK     include/generated/compile.h                    
> >   VDSOSYM arch/x86/vdso/vdso32-int80-syms.lds
> >   VDSOSYM arch/x86/vdso/vdso32-sysenter-syms.lds
> >   VDSOSYM arch/x86/vdso/vdso32-syms.lds
> >   LD      arch/x86/vdso/built-in.o
> >   LD      arch/x86/built-in.o
> >   CC      mm/migrate.o
> > In file included from /tmp/all-yes-config/2.6.33-
> > rc1/arch/x86/include/asm/uaccess.h:571,
> >                  from include/linux/uaccess.h:5,
> >                  from include/linux/highmem.h:6,
> >                  from include/linux/pagemap.h:10,
> >                  from include/linux/mempolicy.h:62,
> >                  from include/linux/migrate.h:5,
> >                  from mm/migrate.c:15:
> > In function ???copy_from_user???,
> >     inlined from ???do_pages_stat??? at mm/migrate.c:1009:
> > /tmp/all-yes-config/2.6.33-rc1/arch/x86/include/asm/uaccess_32.h:213: error: 
> > call to ???copy_from_user_overflow??? declared with attribute error: 
> > copy_from_user() buffer size is not provably correct
> 
> afaik, ingo already queued this fix.
> please wait (very) few days.
> 
> thanks.

hm, the one mm/migrate.c fix we had is already in -rc1:

 b9255850: mm: Adjust do_pages_stat() so gcc can see copy_from_user() is safe

I've Cc:-ed more folks.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/