linux-kernel - Re: [git pull request] ACPI and driver patches for 2.6.33.merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B309FEC.8030406@kernel.org>
Date:	Tue, 22 Dec 2009 02:31:08 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>, Shaohua Li <shaohua.li@...el.com>,
	Len Brown <lenb@...nel.org>
CC:	"Barnes, Jesse" <jesse.barnes@...el.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [git pull request] ACPI and driver patches for 2.6.33.merge

Yinghai Lu wrote:
> Ingo Molnar wrote:
>> * Shaohua Li <shaohua.li@...el.com> wrote:
>>
>>> On Fri, Dec 18, 2009 at 09:28:50AM +0800, Yinghai Lu wrote:
>>>> On Wed, Dec 16, 2009 at 12:06 PM, Len Brown <lenb@...nel.org> wrote:
>>>>> Hi Linus,
>>>>>
>>>>> please pull from:
>>>>>
>>>>> git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git release
>>>>>
>>>> ;..
>>>>> Shaohua Li (3):
>>>>> ? ? ?ACPI: Add a generic API for _OSC -v2
>>>>> ? ? ?ACPI: cleanup pci_root _OSC code.
>>>>> ? ? ?ACPI: Add platform-wide _OSC support.
>>>> it seems these three patches broke the _OSC on my intel new systems.
>>>>
>>>> revert them fix the problem with AER and pciehp and etc
>>> can you give more details? I just cleaned up the _OSC code for AER and 
>>> pciehp, no function changes.
>> Famous last words ;-)
>>
>> Yinghai, i suspect Shaohua needs the kind of info you'd need if you tried to 
>> fix it: acpidump, before/after debug boot log, a description of what goes bad, 
>> etc.
> 
> the so called clean up, change the ret length checking.
> 
> -       if (!output.length)
> -               return AE_NULL_OBJECT;
> -
> 
> +       /* return buffer should have the same length as cap buffer */
> +       if (context->ret.length != context->cap.length)
> +               return AE_NULL_OBJECT;
> 
printk said:

[   54.709165] calling  aer_service_init+0x0/0x2b @ 1
[   56.121190] run_acpi_osc: ret length 40 cap length 12
[   56.124996] aer 0000:00:01.0:pcie02: AER service couldn't init device: _OSC failed

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/