[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87ws0fcixd.fsf@basil.nowhere.org>
Date: Tue, 22 Dec 2009 13:06:06 +0100
From: Andi Kleen <andi@...stfloor.org>
To: Jiri Olsa <jolsa@...hat.com>
Cc: jbaron@...hat.com, mingo@...e.hu, rostedt@...dmis.org,
fweisbec@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] dynamic debug - adding ring buffer storage support
Jiri Olsa <jolsa@...hat.com> writes:
> Hi,
>
> as I use dynamic debug sometimes, I thought it could be useful having
> the possibility to store the output somewhere else than dmesg.
>
> The attached patch implements support for storing dynamic debug
> messages to the ring buffer.
>
> The dynamic debug allows simple addition of new flags,
> so I added 'r' flag for ring buffer storage.
>
> I used the ring buffer implementation from trace framework.
>
> hopefuly this could be any use for others as well...
> plz let me know what you think,
The basic idea sounds good, but doing it all inline is a horrible
idea. That will bloat the kernel considerably because all
users have to expand this code.
I would suggest to implement an out of line dyndebug_printk()
which does all of this out of line.
-Andi
--
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists